-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC - replacing gpt4 with gpt4o in example notebooks #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in many_shot_jailbreak and tree_of_attacks, but switching others over to GPT-4o
rlundeen2
reviewed
Aug 9, 2024
rlundeen2
reviewed
Aug 9, 2024
rlundeen2
reviewed
Aug 9, 2024
rlundeen2
reviewed
Aug 9, 2024
rlundeen2
reviewed
Aug 9, 2024
rlundeen2
reviewed
Aug 9, 2024
romanlutz
reviewed
Aug 12, 2024
nina-msft
reviewed
Aug 12, 2024
nina-msft
reviewed
Aug 12, 2024
nina-msft
reviewed
Aug 12, 2024
nina-msft
reviewed
Aug 12, 2024
nina-msft
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! A few minor comments but otherwise looks great :-) Let me know if you have any questions.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing gpt4 with gpt4o as default in most of the docs and renamed AzureOpenAIChatTarget --> AzureOpenAITextChatTarget. I kept the use of the AzureOpenAITextChatTarget in some of the demos so users can see how it's used, including the first part of the how_to_guide, many_shot_jailbreak, tree_of_attacks_with_pruning, and 3_custom_targets. In the targets folder, gpt4-o is now a core page while gpt-v and text only gpt are moved to supplementary pages. In the multi-modal targets demo, gpt-v is replaced by gpt4-o demo with text and image as input. Targets in the converters, scoring, memory pages use gpt4-o now. Tests remain using text-only gpt, and I changed the naming to AzureOpenAITextChatTarget.
Also added Crucible API key to env_example.
Tests and Documentation
I ran the notebooks without error and used jupyter nbconvert --to script command to convert from notebook to python script. All tests compiled and ran successfully.