Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
# mypy: ignore-errors
was present at the module level inpyrit.memory.memory_models
. In order to have better code safety, we want to remove this line and add proper type-checking. This commit adds in much more type checking, with only a few uses of# type: ignore
. In some cases, those are necessary, though a few can likely be mitigated with the use of generics, particularly inpyrit.memory.duckdb_memory
andpyrit.memory.azure_sql_memory
.CC: @rdheekonda @rdheekonda @romanlutz