Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Fixed mypy Type Failures #269

Merged
merged 6 commits into from
Jul 9, 2024
Merged

FIX Fixed mypy Type Failures #269

merged 6 commits into from
Jul 9, 2024

Conversation

elgertam
Copy link
Contributor

@elgertam elgertam commented Jul 2, 2024

Description

Previously, # mypy: ignore-errors was present at the module level in pyrit.memory.memory_models. In order to have better code safety, we want to remove this line and add proper type-checking. This commit adds in much more type checking, with only a few uses of # type: ignore. In some cases, those are necessary, though a few can likely be mitigated with the use of generics, particularly in pyrit.memory.duckdb_memory and pyrit.memory.azure_sql_memory.

CC: @rdheekonda @rdheekonda @romanlutz

@rlundeen2 rlundeen2 merged commit e76a45e into Azure:main Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants