-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT generalize XPIA orchestrator #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
reviewed
Apr 24, 2024
rlundeen2
reviewed
Apr 24, 2024
rlundeen2
approved these changes
Apr 24, 2024
…generalize_xpia
Co-authored-by: rlundeen2 <137218279+rlundeen2@users.noreply.github.com>
…utz/PyRIT into romanlutz/generalize_xpia
…generalize_xpia
…generalize_xpia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change generalizes the existing
XPIATestOrchestrator
into a base classXPIAOrchestrator
that expects a callback function for the processing portion. There are two concrete implementations in this PR:XPIATestOrchestrator
simulates the processing target execution and is useful for benchmarking.XPIAManualProcessingOrchestrator
waits for operator input, so the operator can manually trigger processing and paste the output afterwards.Another options would be to use the base
XPIAOrchestrator
class and provide a custom callback.Scoring is now optional as well since a scorer may or may not be available. The
process
method was renamed toexecute
since "processing" is the term used for the LLM that is under attack.Tests and Documentation
Tests were expanded to cover the newly created functionality. The example notebook will remain as is for now.