Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Azure Firewall Manager Premium SKU if Premium SKU selected for AZ FW in Hub & Spoke model #890

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jan 16, 2022

Overview/Summary

Deploy Azure Firewall Manager Premium SKU if Premium SKU selected for AZ FW in Hub & Spoke model

This PR fixes/adds/changes/removes

  1. Fixes Azure Firewall Policy tier is Standard when using Azure Firewall Premium SKU #889

Breaking Changes

None

Testing Evidence

Public

URL: https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fjtracey93%2FEnterprise-Scale%2Ffix-889-fw-pol-sku%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fjtracey93%2FEnterprise-Scale%2Ffix-889-fw-pol-sku%2FeslzArm%2Feslz-portal.json

Evidence:

image

image

image

US Gov (Fairfax)

URL: https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fjtracey93%2FEnterprise-Scale%2Ffix-889-fw-pol-sku%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fjtracey93%2FEnterprise-Scale%2Ffix-889-fw-pol-sku%2FeslzArm%2Ffairfaxeslz-portal.json

Evidence: #890 (comment)

China (Mooncake)

Evidence: #890 (comment)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 added bug Something isn't working enhancement New feature or request do not merge engineering engineering work labels Jan 16, 2022
@jtracey93 jtracey93 requested review from a team as code owners January 16, 2022 10:02
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jan 16, 2022
@jtracey93
Copy link
Collaborator Author

@faister & @rspott are you okay to test this one for Mooncake & Fairfax respectively.

Just deploying a premium FW policy and ensure it associates to the AZ FW correctly

@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Jan 16, 2022
@jtracey93
Copy link
Collaborator Author

Sorry to chase @faister & @rspott are you okay to test this one for Mooncake & Fairfax respectively.

Just deploying a premium FW policy and ensure it associates to the AZ FW correctly from the ALZ portal experience

@faister
Copy link
Contributor

faister commented Feb 11, 2022

Sorry to chase @faister & @rspott are you okay to test this one for Mooncake & Fairfax respectively.

Just deploying a premium FW policy and ensure it associates to the AZ FW correctly from the ALZ portal experience

Sure @jtracey93 . I'll spend some time on this come Monday. But there's no ALZ portal experience on Mooncake though, will test the template deployment

@faister
Copy link
Contributor

faister commented Feb 14, 2022

@jtracey93
China (Mooncake)
Testing steps: No Azure China portal experience for deploying ESLZ hub-spoke networking with AZFW. Executed Azure PowerShell below:
image

Evidence:
DeploymentName : EslzMC-hubspoke
Location : chinaeast2
ProvisioningState : Succeeded
Timestamp : 14/02/2022 11:34:13 AM
Mode : Incremental

image

image

@rspott
Copy link

rspott commented Feb 15, 2022

Reviewed deployment to Fairfax. Deployment was successful.

image

image

@jtracey93 jtracey93 merged commit 17d8b3c into Azure:main Feb 16, 2022
@jtracey93 jtracey93 deleted the fix-889-fw-pol-sku branch February 16, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engineering engineering work enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Firewall Policy tier is Standard when using Azure Firewall Premium SKU
4 participants