Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic Settings v2 🎉 #1641

Merged
merged 14 commits into from
May 21, 2024
Merged

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented May 16, 2024

Overview/Summary

This pull request introduces significant changes to the documentation and policy definitions used in the project. The changes primarily focus on the deprecation of custom diagnostic settings in favor of using built-in initiative. The changes also include updates to the RBAC roles in the policy assignments and minor updates to the documentation structure.

Updates to documentation:

Deprecation of custom diagnostic settings:

  • Multiple files in src/resources/Microsoft.Authorization/policyDefinitions/: Marked various policy definitions as deprecated and updated their descriptions to indicate that they are superseded by the built-in initiative. [1] [2] [3] [4] [5] [6] [7] [8]

Updates to policy assignments:

Minor changes:

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added Area: Policy 📝 Issues / PR's related to Policy Area: Diagnostic Settings Area: Diagnostic Settings 🧪 Issues / PR's related to Diagnostic Settings labels May 16, 2024
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label May 17, 2024
@Springstone Springstone marked this pull request as ready for review May 17, 2024 12:16
@Springstone Springstone requested a review from a team as a code owner May 17, 2024 12:16
@Springstone Springstone added this to the policy-refresh-fy24-h2 milestone May 17, 2024
@jtracey93 jtracey93 merged commit fbfba91 into Azure:policy-refresh-q3fy24 May 21, 2024
2 of 4 checks passed
@Springstone Springstone deleted the Diag2 branch May 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Diagnostic Settings 🧪 Issues / PR's related to Diagnostic Settings Area: Diagnostic Settings Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants