-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic Settings v2 🎉 #1641
Merged
Merged
Diagnostic Settings v2 🎉 #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for resource diagnostics policy assignment
Springstone
added
Area: Policy 📝
Issues / PR's related to Policy
Area: Diagnostic Settings
Area: Diagnostic Settings 🧪
Issues / PR's related to Diagnostic Settings
labels
May 16, 2024
Springstone
added
the
PR: Safe to test 🧪
PRs can run more advanced tests that may deploy or access environments
label
May 17, 2024
This was referenced May 17, 2024
jtracey93
requested changes
May 21, 2024
...Arm/managementGroupTemplates/policyAssignments/DINE-ResourceDiagnosticsPolicyAssignment.json
Outdated
Show resolved
Hide resolved
jtracey93
approved these changes
May 21, 2024
jtracey93
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Diagnostic Settings 🧪
Issues / PR's related to Diagnostic Settings
Area: Diagnostic Settings
Area: Policy 📝
Issues / PR's related to Policy
PR: Safe to test 🧪
PRs can run more advanced tests that may deploy or access environments
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request introduces significant changes to the documentation and policy definitions used in the project. The changes primarily focus on the deprecation of custom diagnostic settings in favor of using built-in initiative. The changes also include updates to the RBAC roles in the policy assignments and minor updates to the documentation structure.
Updates to documentation:
docs/wiki/ALZ-Deprecated-Services.md
: Updated the structure of the document and added a note about the deprecation of all ALZ custom Diagnostic Setting features. [1] [2]docs/wiki/Whats-new.md
: Announced the arrival of Diagnostic Settings v2, deprecated the ALZ custom diagnostic settings, and fixed the assignment for a specific policy. [1] [2]Deprecation of custom diagnostic settings:
src/resources/Microsoft.Authorization/policyDefinitions/
: Marked various policy definitions as deprecated and updated their descriptions to indicate that they are superseded by the built-in initiative. [1] [2] [3] [4] [5] [6] [7] [8]Updates to policy assignments:
eslzArm/managementGroupTemplates/policyAssignments/DINE-ResourceDiagnosticsPolicyAssignment.json
: Updated the diagnostic settings assignment to use the new built-in initiative and updated the description and display name accordingly.eslzArm/managementGroupTemplates/policyAssignments/MODIFY-AUM-VMCheckUpdatesPolicyAssignment.json
: Updated the RBAC role used in the policy assignment. [1] [2]eslzArm/managementGroupTemplates/policyAssignments/MODIFY-AUM-VMHybridCheckUpdatesPolicyAssignment.json
: Updated the RBAC role used in the policy assignment. [1] [2]Minor changes:
eslzArm/managementGroupTemplates/roleDefinitions/customRoleDefinitions.json
: Updated the Bicep generator version and template hash.Testing URLs
Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)