Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on GH issue #1486 #1621

Merged
merged 74 commits into from
May 3, 2024
Merged

Fix on GH issue #1486 #1621

merged 74 commits into from
May 3, 2024

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Apr 22, 2024 •
edited
Loading

Overview/Summary

Fixing the bug with Configure Azure Machine Learning workspace to use private DNS zones policy where secondPrivateDnsZoneId parameter was missing which was leaving AML private endpoints incomplete

This PR fixes/adds/changes/removes

  1. Deploy-Private-DNS-Zones.json
  2. DINE-PrivateDNSZonesPolicyAssignment.json

Breaking Changes

  1. N/A

Testing Evidence

Ekran görüntüsü 2024-04-16 113344
Ekran görüntüsü 2024-04-16 113439
Ekran görüntüsü 2024-04-16 113330

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Recep Ozkurt and others added 14 commits February 21, 2024 09:31
Update whats new file to avoid conflicts
4f7bf60
Merge branch 'PrivateDNSZones_BugFix1485' of https://github.com/rozku…
3e84375 
…rt/Enterprise-Scale-rozkurt into PrivateDNSZones_BugFix1485
Update whats new for March 2024
edd848e
.
cab578c
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
c857425 
…rprise-Scale into PrivateDNSZones_BugFix1485
remove duplicated lines from whats-new
1476cf0
Update whats-new as per Sacha's request
8cd1ab4
@github-actions
Auto-update Portal experience [Springstone/281f03f3]
d9373b0
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
e229249 
…rprise-Scale into PrivateDNSZones_BugFix1485
@github-actions
Auto-update Portal experience [rozkurt/281f03f3]
b990707
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
121d9b9 
…rprise-Scale into PrivateDNSZones_BugFix1485
Merge branch 'PrivateDNSZones_BugFix1485' of https://github.com/rozku…
b12ca7a 
…rt/Enterprise-Scale-rozkurt into PrivateDNSZones_BugFix1485
Add AML WS Secondary Private DNS Zone ID
11d44d1
Update Whats-new
39025bc
@rozkurt rozkurt requested a review from a team as a code owner April 22, 2024 09:32
@Springstone Springstone added the Area: Policy 📝 Issues / PR's related to Policy label Apr 22, 2024
@Springstone Springstone added this to the policy-refresh-fy24-q3 milestone Apr 22, 2024
@Springstone Springstone added the Area: Networking 🌐 Issues / PR's related to Networking label Apr 22, 2024
@Springstone Springstone requested a review from jtracey93 April 22, 2024 12:31
Springstone
Springstone approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Apr 22, 2024
@Springstone Springstone mentioned this pull request Apr 29, 2024
Closed
@jtracey93 jtracey93 closed this Apr 30, 2024
@jtracey93 jtracey93 reopened this Apr 30, 2024
@jtracey93 jtracey93 merged commit b646a5d into Azure:policy-refresh-q3fy24 May 3, 2024
2 of 4 checks passed
@Springstone Springstone mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Springstone Springstone Springstone approved these changes

@jtracey93 jtracey93 Awaiting requested review from jtracey93

Assignees
No one assigned
Labels
Area: Networking 🌐 Issues / PR's related to Networking Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
policy-refresh-fy24-h2
Development

Successfully merging this pull request may close these issues.
3 participants
@rozkurt @Springstone @jtracey93