-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New generic policy for PaaS resources private endpoint to override Private DNS zone. #1618
Conversation
New generic policy for PaaS resources private endpoint to override Private DNS zone.
Configure private DNS zone group to override the DNS resolution for PaaS services private endpoint, allowed values defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort, some minor fixes needed.
Please also add an entry in What's New for what it is you're adding in this pull request. Using the Policy Refresh Q3 Fy24 section, add a bullet describing the policies you're adding.
...rization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint-Allowed values.json
Outdated
Show resolved
Hide resolved
...rization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint-Allowed values.json
Outdated
Show resolved
Hide resolved
...rization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint-Allowed values.json
Outdated
Show resolved
Hide resolved
...rization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint-Allowed values.json
Outdated
Show resolved
Hide resolved
...rization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint-Allowed values.json
Outdated
Show resolved
Hide resolved
...Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint.json
Outdated
Show resolved
Hide resolved
...Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint.json
Outdated
Show resolved
Hide resolved
...Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint.json
Outdated
Show resolved
Hide resolved
...Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-Private endpoint.json
Outdated
Show resolved
Hide resolved
@rozkurt can you please also review this PR. |
…ed values.json to Deploy-Private DNS zone ID-PaaS-PE.json Policy name shortened Version edited Category edited Indents fixed
…to Deploy-Private DNS zone-PaaS-PE-Generic.json Policy name edited Version edited Category edited Fixed indents
Updated on addition of new custom policy - Added new custom policy "Deploy-Private DNS zone ID-PaaS-PE" - Added new custom policy "Deploy-Private DNS zone-PaaS-PE-Generic"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GREAT effort, really appreciate your contribution. Some more changes, mostly around ALZ specifics like escaping parameters :). Please also add these new policies to the polices.bicep for full testing.
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone ID-PaaS-PE.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone ID-PaaS-PE.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone ID-PaaS-PE.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone ID-PaaS-PE.json
Outdated
Show resolved
Hide resolved
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone ID-PaaS-PE.json
Outdated
Show resolved
Hide resolved
...urces/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-PE-Generic.json
Outdated
Show resolved
Hide resolved
...urces/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-PE-Generic.json
Outdated
Show resolved
Hide resolved
...urces/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-PE-Generic.json
Outdated
Show resolved
Hide resolved
...urces/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-PE-Generic.json
Outdated
Show resolved
Hide resolved
...urces/Microsoft.Authorization/policyDefinitions/Deploy-Private DNS zone-PaaS-PE-Generic.json
Outdated
Show resolved
Hide resolved
…rivate-DNS-zone-ID-PaaS-PE.json Fixed Policy name and addressed escaping parameters.
…loy-Private-DNS-zone-PaaS-PE-Generic.json Policy name edited Addressed escaping parameters
Removed space from policy name
Removed space from policy name
Added below 2 Policy Definition resources to load Deploy-Private-DNS-zone-ID-PaaS-PE.json Deploy-Private-DNS-zone-PaaS-PE-Generic.json
Display name space issue fixed
Deleted the info on Deploy-Private-DNS-Group ID policy as only generic policy "Deploy-Private-DNS-Generic" will serve the purpose
Deleted the info on Deploy-Private-DNS-Group ID policy as only generic policy "Deploy-Private-DNS-Generic" will serve the purpose
…-Private-DNS-GroupID.json Deleted the policy as generic policy suffice the ask
I know this has been already merged but what do you think about potential improvement in terms of adding additional parameter to be able to specify Similar feature-request requested for Azure built-in policies but without any response - Azure/azure-policy#1050 |
I would love to use this, but am not even able to create the policy definition. This is what happens when I try to create it using Azure PowerShell:
I assume I must be doing something wrong, and that the policy content in the .json file isn't intended to be imported as-is.... EDIT: Yes it was probably me. When I copy the content from here instead, it seems to import just fine: https://www.azadvertizer.com/azpolicyadvertizer/Deploy-Private-DNS-Generic.html. Sorry for the noise, and thanks for the work on this policy, looks very useful! |
Overview/Summary
Policy Refresh Q3 Fy24
This PR fixes/adds/changes/removes
1.Added 2 new custom policy definitions
2.Policy 1: Deploy-Private DNS zone ID-PaaS-PE, this policy will DINE-configure private DNS zone group to override the DNS resolution for PaaS services private endpoint, added services which supports private DNS but doesn't have built in policy exist
3.Policy 2: Deploy-Private DNS zone-PaaS-PE-Generic, this policy will DINE-configure private DNS zone group to override the DNS resolution for PaaS services private endpoint, it is generic for the services which supports private DNS but doesn't have built in policy exist and also for the new services which supports private DNS in future
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
The below URLs can be updated where the placeholders are, look for
Ravivarman13
&main
, to allow you to test your portal deployment experience.Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)