Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Fixes #1597

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Mar 11, 2024

Overview/Summary

This pull request primarily involves updates to the eslzArm/eslz-portal.json and docs/wiki/Whats-new.md files. The changes include updates to the policy documentation, modifications to the eslz-portal.json file to make certain fields required, provide more detailed tooltips, and correct a typo.

Policy documentation updates:

  • docs/wiki/Whats-new.md: Added a section for Policy Refresh FY23Q3 and updated the Audit-PrivateLinkDnsZones display name to include the fact it can be audit or deny.

eslz-portal.json modifications:

  • Made the constraints field for Management subscription required.
  • Updated the toolTip text for the "Enable DDoS Network Protection" field to include a link to DDoS Network Protection pricing.
  • Corrected a typo in the text field of the options object.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone requested a review from a team as a code owner March 11, 2024 14:08
@Springstone Springstone changed the title Portal updates Portal Fixes Mar 11, 2024
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Mar 14, 2024
@jtracey93 jtracey93 merged commit 9887791 into Azure:policy-refresh-q3fy24 Mar 19, 2024
3 checks passed
@Springstone Springstone deleted the PortalUpdates branch March 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants