Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private DNS Zones- Bug Fix1485 #1578

Merged
merged 68 commits into from
Mar 8, 2024
Merged

Private DNS Zones- Bug Fix1485 #1578

merged 68 commits into from
Mar 8, 2024

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Feb 21, 2024

Overview/Summary

This PR is targeting bug report #1485 and it's adding new built-in policies into "Deploy-Private-DNS-Zones" initiative and assignment. All the new policy names are documented on Whats-New file.

This PR fixes/adds/changes/removes

  1. Updated Deploy-Private-DNS-Zones.json
  2. Updated DINE-PrivateDNSZonesPolicyAssignment.json
  3. Updated eslz-portal.json

Breaking Changes

  1. N\A

Testing Evidence

Ekran görüntüsü 2024-02-21 114252
Ekran görüntüsü 2024-02-21 115305
Ekran görüntüsü 2024-02-21 115446

Testing URLs

Azure Public

[Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@rozkurt rozkurt requested a review from a team as a code owner February 21, 2024 10:24
jtracey93
jtracey93 requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of changes please @rozkurt

cc: @Springstone

docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
Springstone
Springstone approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Springstone Springstone added PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Type: Enhancement ✨ New feature or request Area: Policy 📝 Issues / PR's related to Policy labels Mar 7, 2024
@Springstone Springstone added this to the policy-refresh-fy24-q3 milestone Mar 7, 2024
@Springstone Springstone closed this Mar 7, 2024
@Springstone Springstone reopened this Mar 7, 2024
@jtracey93 jtracey93 merged commit f002346 into Azure:policy-refresh-q3fy24 Mar 8, 2024
1 check passed
This was referenced Apr 29, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

@Springstone Springstone Springstone approved these changes

Assignees
No one assigned
Labels
Area: Policy 📝 Issues / PR's related to Policy PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Type: Enhancement ✨ New feature or request
Projects
None yet
Milestone
policy-refresh-fy24-h2
Development

Successfully merging this pull request may close these issues.
3 participants
@rozkurt @Springstone @jtracey93