Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defender for Cloud provisioning cleanup - remove D4C DNS and VM Vulnerability Assessment Provider #1577

Merged
merged 28 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
889edea
Removing MDFC Dns and Updating Portal UI
Springstone Feb 16, 2024
1923991
Remove deprecated Defender for Cloud for DNS and update Deploy-MDFC-C…
Springstone Feb 16, 2024
a225744
Remove vulnerability assessment provider and enableAscForDns from tes…
Springstone Feb 16, 2024
3a2fa33
Update Defender for Cloud for DNS version to 8.0.0
Springstone Feb 16, 2024
b5d8dac
Auto-update Portal experience [Springstone/eaa07927]
github-actions[bot] Feb 16, 2024
8d04848
Fix bugs and remove unnecessary options in Portal Accelerator
Springstone Feb 16, 2024
05d7769
Merge branch 'D4cCleanup' of https://github.com/Springstone/Enterpris…
Springstone Feb 16, 2024
ad02a0f
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
Springstone Mar 5, 2024
d10584a
Auto-update Portal experience [Springstone/9f44e1dd]
github-actions[bot] Mar 5, 2024
3e67163
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
Springstone Mar 8, 2024
88c3893
Auto-update Portal experience [Springstone/f0023468]
github-actions[bot] Mar 8, 2024
bc9ab2a
Update policy assignment and policy set definition for Deploy-MDFC-Co…
Springstone Mar 19, 2024
72e8eec
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Mar 19, 2024
22e0db4
Remove deprecated Defender for Cloud for DNS and update initiative as…
Springstone Mar 19, 2024
6c4b7a0
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Mar 19, 2024
e8be5e8
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
Springstone Mar 19, 2024
0980776
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Mar 19, 2024
281f400
Add deprecation notice for Microsoft Defender for Cloud configuration
Springstone Mar 20, 2024
4106b5c
Merge branch 'Azure:main' into D4cCleanup
Springstone Mar 26, 2024
587f1cc
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Mar 26, 2024
fed7aa2
Add new policy set definition for MDFC configuration
Springstone Mar 26, 2024
132e0e5
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Mar 26, 2024
f668845
Update policy assignments and definitions for Microsoft Defender for …
Springstone Apr 23, 2024
926d314
Auto-update Portal experience [Springstone/651f57a7]
github-actions[bot] Apr 23, 2024
d4e83fc
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
Springstone May 6, 2024
f165d20
Auto-update Portal experience [Springstone/b646a5d5]
github-actions[bot] May 6, 2024
bb9b835
Merge branch 'policy-refresh-q3fy24' of https://github.com/Azure/Ente…
Springstone May 6, 2024
6064b69
Auto-update Portal experience [Springstone/79c74f4d]
github-actions[bot] May 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/wiki/ALZ-Deprecated-Services.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Policies being deprecated:
| Public network access should be disabled for MariaDB<br>ID: [`Deny-PublicEndpoint-MariaDB`](https://www.azadvertizer.net/azpolicyadvertizer/Deny-PublicEndpoint-MariaDB.html) | [`fdccbe47-f3e3-4213-ad5d-ea459b2fa077`](https://www.azadvertizer.net/azpolicyadvertizer/fdccbe47-f3e3-4213-ad5d-ea459b2fa077.html) | Deprecating policies for MariaDB see [`ALZ Policy FAQ & Tips`](https://github.com/Azure/Enterprise-Scale/blob/main/docs/wiki/ALZ-Policies-FAQ.md). |
| Diagnostic Settings for MariaDB to Log Analytics Workspace <br>ID: [`Deploy-Diagnostics-MariaDB`](https://www.azadvertizer.net/azpolicyadvertizer/Deploy-Diagnostics-MariaDB.html) | Deprecating due to service retirement | Deprecating policies for MariaDB, see [`ALZ Policy FAQ & Tips`](./ALZ-Policies-FAQ) |
| Deploy SQL Database Vulnerability Assessments<br>ID: [`Deploy-Sql-vulnerabilityAssessments`](https://www.azadvertizer.net/azpolicyadvertizer/Deploy-Sql-vulnerabilityAssessments.html) | [`Deploy-Sql-vulnerabilityAssessments_20230706`](https://www.azadvertizer.net/azpolicyadvertizer/Deploy-Sql-vulnerabilityAssessments_20230706.html) | Custom policy replaced by updated custom policy providing bug fix |
| Deploy Microsoft Defender for Cloud configuration<br>ID: [`Deploy-MDFC-Config`](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config.html) | [`Deploy-MDFC-Config_20240319`](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config_20240319.html) | Custom initiative replaced by updated custom initiative due to breaking changes |

### More Information

Expand Down
2 changes: 2 additions & 0 deletions docs/wiki/Whats-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:
- Added the [Configure Recovery Services vaults to use private DNS zones for backup](https://www.azadvertizer.net/azpolicyadvertizer/af783da1-4ad1-42be-800d-d19c70038820.html) built-in policy to the "Deploy-Private-DNS-Zones" initiative and assignment.
- Added the [Configure a private DNS Zone ID for table groupID](https://www.azadvertizer.net/azpolicyadvertizer/028bbd88-e9b5-461f-9424-a1b63a7bee1a.html) built-in policy to the "Deploy-Private-DNS-Zones" initiative and assignment.
- Added the [Configure a private DNS Zone ID for table_secondary groupID](https://www.azadvertizer.net/azpolicyadvertizer/c1d634a5-f73d-4cdd-889f-2cc7006eb47f.html) built-in policy to the "Deploy-Private-DNS-Zones" initiative and assignment.
- Removed Defender for Cloud for DNS, as this is now deprecated and is included in Defender for Servers. Deprecated [Deploy-MDFC-Config](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config.html) initiative, and superseded with [Deploy-MDFC-Config_20240319](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config_20240319.html) to minimize breaking change impact on existing deployments.
- Added new initiative and default assignment for [Enforce-Backup](https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Enforce-Backup.html) scoped to the Landing Zones and Platform management groups in Audit mode:
- Added the [[Preview]: Immutability must be enabled for backup vaults](https://www.azadvertizer.net/azpolicyadvertizer/2514263b-bc0d-4b06-ac3e-f262c0979018.html) built-in policy
- Added the [[Preview]: Immutability must be enabled for Recovery Services vaults](https://www.azadvertizer.net/azpolicyadvertizer/d6f6f560-14b7-49a4-9fc8-d2c3a9807868.html) built-in policy
Expand Down Expand Up @@ -104,6 +105,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:
- Bug fix for Portal Accelerator. userAssignedIdentityResourceGroup has been added as output for the Portal UI, this fixes deploying the Resource Group with a custom name.
- Bug fix for Portal Accelerator. `subscriptionIds` now uses lambda function to obtain the subscription IDs from `corpConnectedLzSubscriptionId`. This fixes the Invalid Template error when selecting a corp connected landing zone deployment.
- Bug fix for Portal Accelerator. `connectivitySubscriptionId` is now skipped when no networking components are deployed. This fixes an InvalidTemplateDeployment error deploying the Resource Group for UAMI.
- From Portal Accelerator: removed the options to select VM vulnerability assessment provider and to select Defender for Cloud for DNS. These are now default to the recommended settings.

### AMA Update for the Portal Accelerator

Expand Down
22 changes: 0 additions & 22 deletions eslzArm/eslz-portal.json
Original file line number Diff line number Diff line change
Expand Up @@ -624,26 +624,6 @@
]
}
},
{
"name": "vulnerabilityAssessmentProvider",
"type": "Microsoft.Common.OptionsGroup",
"label": "Choose the Microsoft Defender for Cloud for servers vulnerability assessments provider",
"defaultValue": "Microsoft Defender vulnerability management (recommended)",
"toolTip": "Choose the preferred vulnerability assessment provider for Microsoft Defender for Cloud for servers vulnerability assessments.<br>Uses the custom initiative <a href=\"https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config.html\">Deploy Microsoft Defender for Cloud configuration</a>.",
"visible": "[and(equals(steps('management').enableAsc,'Yes'), equals(steps('management').enableAscForServersVulnerabilityAssessments,'DeployIfNotExists'))]",
"constraints": {
"allowedValues": [
{
"label": "Microsoft Defender for Cloud integrated Qualys scanner",
"value": "default"
},
{
"label": "Microsoft Defender vulnerability management (recommended)",
"value": "mdeTvm"
}
]
}
},
{
"name": "enableAscForOssDb",
"type": "Microsoft.Common.OptionsGroup",
Expand Down Expand Up @@ -5489,7 +5469,6 @@
"emailContactAsc": "[steps('management').emailContactAsc]",
"enableAscForServers": "[steps('management').enableAscForServers]",
"enableAscForServersVulnerabilityAssessments": "[steps('management').enableAscForServersVulnerabilityAssessments]",
"vulnerabilityAssessmentProvider": "[steps('management').vulnerabilityAssessmentProvider]",
"enableAscForOssDb": "[steps('management').enableAscForOssDb]",
"enableAscForCosmosDbs": "[steps('management').enableAscForCosmosDbs]",
"enableAscForAppServices": "[steps('management').enableAscForAppServices]",
Expand All @@ -5500,7 +5479,6 @@
"enableAscForArm": "[steps('management').enableAscForArm]",
"enableAscForApis": "[steps('management').enableAscForApis]",
"enableAscForCspm": "[steps('management').enableAscForCspm]",
"enableAscForDns": "[steps('management').enableAscForDns]",
"enableAscForContainers": "[steps('management').enableAscForContainers]",
"enableMDEndpoints": "[steps('management').enableMDEndpoints]",
"enableMonitorBaselines": "[steps('monitor').enableMonitorBaselines]",
Expand Down
25 changes: 0 additions & 25 deletions eslzArm/eslzArm.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,6 @@
"Disabled"
]
},
"vulnerabilityAssessmentProvider": {
"type": "string",
"defaultValue": "mdeTvm",
"allowedValues": [
"default",
"mdeTvm"
]
},
"enableAscForOssDb": {
"type": "string",
"allowedValues": [
Expand Down Expand Up @@ -194,14 +186,6 @@
],
"defaultValue": "Disabled"
},
"enableAscForDns": {
"type": "string",
"allowedValues": [
"Disabled",
"DeployIfNotExists"
],
"defaultValue": "Disabled"
},
"enableAscForContainers": {
"type": "string",
"allowedValues": [
Expand Down Expand Up @@ -2481,9 +2465,6 @@
"enableAscForServersVulnerabilityAssessments": {
"value": "[parameters('enableAscForServersVulnerabilityAssessments')]"
},
"vulnerabilityAssessmentProvider": {
"value": "[parameters('vulnerabilityAssessmentProvider')]"
},
"enableAscForSql": {
"value": "[parameters('enableAscForSql')]"
},
Expand Down Expand Up @@ -2511,9 +2492,6 @@
"enableAscForCspm": {
"value": "[parameters('enableAscForCspm')]"
},
"enableAscForDns": {
"value": "[parameters('enableAscForDns')]"
},
"enableAscForOssDb": {
"value": "[parameters('enableAscForOssDb')]"
},
Expand Down Expand Up @@ -2698,9 +2676,6 @@
},
"enableAscForArm": {
"value": "[parameters('enableAscForArm')]"
},
"enableAscForDns": {
"value": "[parameters('enableAscForDns')]"
}
}
}
Expand Down
6 changes: 0 additions & 6 deletions eslzArm/eslzArm.test.param.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@
"enableAscForServersVulnerabilityAssessments": {
"value": "DeployIfNotExists"
},
"vulnerabilityAssessmentProvider": {
"value": "default"
},
"enableAscForOssDb": {
"value": "DeployIfNotExists"
},
Expand Down Expand Up @@ -80,9 +77,6 @@
"enableAscForCspm": {
"value": "DeployIfNotExists"
},
"enableAscForDns": {
"value": "DeployIfNotExists"
},
"enableAscForContainers": {
"value": "DeployIfNotExists"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@
],
"defaultValue": "Disabled"
},
"vulnerabilityAssessmentProvider": {
"type": "string",
"allowedValues": [
"default",
"mdeTvm"
],
"defaultValue": "mdeTvm"
},
"enableAscForSql": {
"type": "string",
"allowedValues": [
Expand Down Expand Up @@ -112,14 +104,6 @@
],
"defaultValue": "Disabled"
},
"enableAscForDns": {
"type": "string",
"allowedValues": [
"Disabled",
"DeployIfNotExists"
],
"defaultValue": "Disabled"
},
"enableAscForOssDb": {
"type": "string",
"allowedValues": [
Expand Down Expand Up @@ -155,7 +139,7 @@
},
"variables": {
"policyDefinitions": {
"deployAzureSecurity": "[concat('/providers/Microsoft.Management/managementGroups/', parameters('topLevelManagementGroupPrefix'), '/providers/Microsoft.Authorization/policySetDefinitions/Deploy-MDFC-Config')]"
"deployAzureSecurity": "[concat('/providers/Microsoft.Management/managementGroups/', parameters('topLevelManagementGroupPrefix'), '/providers/Microsoft.Authorization/policySetDefinitions/Deploy-MDFC-Config_20240319')]"
},
"policyAssignmentNames": {
"azureSecurity": "Deploy-MDFC-Config",
Expand Down Expand Up @@ -210,9 +194,6 @@
"enableAscForServersVulnerabilityAssessments": {
"value": "[parameters('enableAscForServersVulnerabilityAssessments')]"
},
"vulnerabilityAssessmentProvider": {
"value": "[parameters('vulnerabilityAssessmentProvider')]"
},
"enableAscForSql": {
"value": "[parameters('enableAscForSql')]"
},
Expand All @@ -234,9 +215,6 @@
"enableAscForArm": {
"value": "[parameters('enableAscForArm')]"
},
"enableAscForDns": {
"value": "[parameters('enableAscForDns')]"
},
"enableAscForOssDb": {
"value": "[parameters('enableAscForOssDb')]"
},
Expand Down

Large diffs are not rendered by default.

Springstone marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
"scope": null,
"properties": {
"policyType": "Custom",
"displayName": "Deploy Microsoft Defender for Cloud configuration",
"description": "Deploy Microsoft Defender for Cloud configuration",
"displayName": "[Deprecated]: Deploy Microsoft Defender for Cloud configuration",
"description": "Deploy Microsoft Defender for Cloud configuration. Superseded by https://www.azadvertizer.net/azpolicyinitiativesadvertizer/Deploy-MDFC-Config_20240319.html",
"metadata": {
"version": "7.0.0",
"version": "7.0.0-deprecated",
"category": "Security Center",
"source": "https://github.com/Azure/Enterprise-Scale/",
"deprecated": true,
"supersededBy": "Deploy-MDFC-Config_20240319",
"alzCloudEnvironments": [
"AzureCloud"
]
Expand Down
Loading
Loading