Adds attribute support in Channel, Bootstrap [#78] #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myagley, @mtuchkov, @mastermanu please take a look. |
| lock (head) | ||
| { | ||
| DefaultAttribute curr = head; | ||
| for (;;) |
|
LGTM |
Motivation: Increasing feature parity and dev convenience through addition of arbitrary data assignment on Channel and related API on Bootstrap classes. Modifications - Introduced IAttributeMap, IAttribute<T>, IConstant and related impl artifacts. - Moved ChannelOption to common constant codebase - AbstractChannel now inherits from DefaultChannelMap - Reflection-less child optoins config in ServerBootstrap - Extra: minor closure allocation fixes, internal API fixes. Result: Attributes can be set on Channels, better code portability in Bootstrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Increasing feature parity and dev convenience through addition of arbitrary data assignment on Channel and related API on Bootstrap classes.
Modifications
IAttributeMap,IAttribute<T>,IConstantand related impl artifacts.ChannelOptionto common constant codebaseAbstractChannelnow inherits fromDefaultChannelMapServerBootstrapResult:
Attributes can be set on Channels, better code portability in Bootstrap.