Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pooled buffer's AdjustCapacity breaks on fall-through to unpooled implementation #71

Closed
nayato opened this issue Feb 17, 2016 · 0 comments
Closed

Pooled buffer's AdjustCapacity breaks on fall-through to unpooled implementation #71

nayato opened this issue Feb 17, 2016 · 0 comments

Comments

@nayato
Copy link
Member

nayato commented Feb 17, 2016

Buffer's length is not updated if buffer's growth results in a switch to unpooled underlying array. That leads to failures in consecutive operations involving access to buffer's area higher than original length.
nayato added a commit to nayato/DotNetty that referenced this issue Feb 17, 2016
@nayato
Fixes pooled buffer's AdjustCapacity to properly set the length
1f77e0c 
Motivation:
Fix a bug Azure#71.

Modifications:
Set length property of a PooledByteBuffer in case of a switch of underlying array to unpooled.

Results:
PooledByteBufferAllocator can work with buffers bigger than pooled buffer's original capacity.
@nayato nayato mentioned this issue Feb 17, 2016
Merged
@nayato nayato closed this as completed Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nayato