base & tools: Consolidate PowerShell setup #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test image: |
surajssd
force-pushed
the
consolidate-powershell-setup
branch
2 times, most recently
from
25964a2
to
2be1f3b
Compare
darrentu
reviewed
May 9, 2024
| COPY ./linux/powershell/Invoke-PreparePowerShell.ps1 linux/powershell/Invoke-PreparePowerShell.ps1 | ||
| # Copy and run script to install Powershell modules and setup Powershell machine profile | ||
| COPY ./linux/powershell/ powershell | ||
| RUN /usr/bin/pwsh -File ./powershell/setupPowerShell.ps1 -image Base && \ |
There was a problem hiding this comment.
hmm, that part is for the base.Dockerfile?
There was a problem hiding this comment.
Yes:
CloudShell/linux/base.Dockerfile
Lines 194 to 196 in f3e3630
surajssd
force-pushed
the
consolidate-powershell-setup
branch
from
2be1f3b
to
c94b57b
Compare
surajssd
force-pushed
the
consolidate-powershell-setup
branch
from
c94b57b
to
3ac0fce
Compare
darrentu
approved these changes
Jun 25, 2024
Move the powershell module installation from the base Dockerfile to the tools Dockerfile into one RUN command. This will help in reducing the number of layers in the Docker image, thus also reducing the size of the image. Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
surajssd
force-pushed
the
consolidate-powershell-setup
branch
from
3ac0fce
to
f170918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the powershell module installation from the
base Dockerfile to the tools Dockerfile into one
RUN command. This will help in reducing the number of layers in the Docker image, thus also reducing
the size of the image.