Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to 1es pool #602

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Feb 27, 2024

This PR updates publishing to ACR with new 1es pool eliminating the need for ACR_USERNAME and ACR_PASSWORD. Once this workflow is successfully, those secrets can be deleted.

updated b2k prod ACR endpoint to bridgetok8s.azurecr.io which is a new registry with zone redundant - this change was done to be in compliance with organization policies. Old ACR will be deleted and will be announced to users that they need to update to latest version before releasing this to marketplace.

@hsubramanianaks hsubramanianaks marked this pull request as ready for review February 27, 2024 03:55
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️🙏☕️ Thanks, looks good to me, and I believe the new registry server used is all on-boarded, changes look good.

@hsubramanianaks hsubramanianaks merged commit 7fc23c3 into Azure:main Feb 27, 2024
10 checks passed
@hsubramanianaks hsubramanianaks deleted the update-1es-runner branch February 27, 2024 16:03
@jruckert
Copy link

@hsubramanianaks @Tatsinnit whilst this is a good change, it seems that the old azurecr.io site is now no longer operational and no new code to reflect this change has been released since Jan 2024. We can no longer bridge anymore as images on the old production azurecr.io site are no longer available. https://bridgetokubernetes.blob.core.windows.net/zipv2/lks.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants