Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial changes for including arm64 binaries #290

Merged
merged 67 commits into from
Nov 7, 2023

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Jul 7, 2023

This PR is to support

  • arm 64 binaries for 3 platforms linux, windows and macos as part of build systems so that CLI, extensions can use to download based on the arch.
  • support arm architectures clusters (without these changes it would error: exec format error).
  • update docker images for samples/todoapp to support both amd64 and arm64 architectures.
  • update docker images for routingmanager, lpkremoteagent and lpkrestorationjob to support both amd64 and arm64 architectures.
  • update envoy image to support both architectures.

Fixes
#291
#273

Internal Azure pipelines that is passing
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8037558&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b

Storage account screenshot:
image

  • Tested with ARM cluster, B2K works fine.
  • Tested with non-ARM cluster, B2k work fine.

@hsubramanianaks hsubramanianaks marked this pull request as ready for review July 18, 2023 15:51
@hsubramanianaks
Copy link
Collaborator Author

/ok-to-test sha=45e7116

1 similar comment
@hsubramanianaks
Copy link
Collaborator Author

/ok-to-test sha=45e7116

@hsubramanianaks hsubramanianaks marked this pull request as draft October 11, 2023 21:41
@hsubramanianaks hsubramanianaks force-pushed the arm64-changes branch 2 times, most recently from 8e1d795 to 3a129dd Compare October 23, 2023 21:43
Tatsinnit
Tatsinnit previously approved these changes Oct 23, 2023
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊❤️☕️ Thank you so much for this, looks good, beside couple of comments:

  • The arm64 solution is not for all portable arm distro given we don't have rasberrypi setup I am not sure if this will work on that distro.
  • Secondly, we can open tracking item as a repercussion for various other linux-arm64 distro which needs minor tweaking which will mean more common-place solution in wider run.

Thank you so much all, and Hari for this.

.github/workflows/acr-build-publish.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
peterbom
peterbom previously approved these changes Oct 24, 2023
Copy link

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks for your patience with me @hsubramanianaks!

Tatsinnit
Tatsinnit previously approved these changes Oct 28, 2023
@cxznmhdcxz
Copy link
Member

@hsubramanianaks Tested on arm & x64 platform with arm arch clusters and the origin x64 clusters. The extension works fine.

Copy link

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is noted here, but I think this can be addressed at a later stage.

@hsubramanianaks hsubramanianaks merged commit 10a361c into Azure:main Nov 7, 2023
9 checks passed
@hsubramanianaks hsubramanianaks deleted the arm64-changes branch November 7, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants