-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial changes for including arm64 binaries #290
Conversation
…Kubernetes into arm64-changes
/ok-to-test sha=45e7116 |
1 similar comment
/ok-to-test sha=45e7116 |
8e1d795
to
3a129dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊❤️☕️ Thank you so much for this, looks good, beside couple of comments:
- The
arm64
solution is not for all portablearm
distro given we don't have rasberrypi setup I am not sure if this will work on that distro. - Secondly, we can open tracking item as a repercussion for various other linux-arm64 distro which needs minor tweaking which will mean more common-place solution in wider run.
Thank you so much all, and Hari for this.
…Kubernetes into arm64-changes
222ce45
to
11525d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - thanks for your patience with me @hsubramanianaks!
9d7099d
@hsubramanianaks Tested on arm & x64 platform with arm arch clusters and the origin x64 clusters. The extension works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is noted here, but I think this can be addressed at a later stage.
This PR is to support
Fixes
#291
#273
Internal Azure pipelines that is passing
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8037558&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b
Storage account screenshot: