-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iptables wait option #289
Merged
Merged
Iptables wait option #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubramanianaks
requested review from
a team,
Tatsinnit and
sabbour
as code owners
July 6, 2023 21:29
peterbom
previously approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, what is the behaviour of iptables
if you don't specify the -w
parameter? It fails immediately?
Vidya2606
previously approved these changes
Jul 7, 2023
yes it would fail immediately default is 1 second.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: peterbom ***@***.***>
Sent: Thursday, July 6, 2023 6:04:12 PM
To: Azure/Bridge-To-Kubernetes ***@***.***>
Cc: Hariharan Subramanian ***@***.***>; Author ***@***.***>
Subject: Re: [Azure/Bridge-To-Kubernetes] Iptables wait option (PR #289)
@peterbom approved this pull request.
Out of interest, what is the behaviour of iptables if you don't specify the -w parameter? It fails immediately?
—
Reply to this email directly, view it on GitHub<#289 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZH32JRSA2H344KSWFKDQ7DXO4Y5ZANCNFSM6AAAAAA2A7RBIE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Tatsinnit
reviewed
Jul 7, 2023
Tatsinnit
previously approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍💭
hsubramanianaks
dismissed stale reviews from Tatsinnit, Vidya2606, and peterbom
via
July 7, 2023 12:42
bb5b72b
Tatsinnit
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #223.