Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed swaped arguments #255

Merged
merged 5 commits into from
May 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common.tests/FixedSizeStringBuilderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void AppendLong()
sb.AppendLine("12345");
sb.Append("678910");

Assert.Equal(sb.ToString(), "...678910");
Assert.Equal("...678910", sb.ToString());
Assert.True(sb.MaxLengthReached);
}

Expand All @@ -42,7 +42,7 @@ public void AppendLongValue()

sb.Append("12345678910");

Assert.Equal(sb.ToString(), "...2345678910");
Assert.Equal("...2345678910", sb.ToString());
Assert.True(sb.MaxLengthReached);
}

Expand Down
4 changes: 2 additions & 2 deletions src/library.tests/PortMappingManagerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ public async void GetRemoteToFreeLocalPortMappings_HeadlessService(int numServic
var assignedPorts = new HashSet<int>();
foreach (var endpoint in endpoints) {
foreach (var port in endpoint.Ports) {
Assert.NotEqual(port.LocalPort, -1);
Assert.False(assignedPorts.Contains(port.LocalPort));
Assert.NotEqual(-1, port.LocalPort);
Assert.DoesNotContain(port.LocalPort, assignedPorts);
assignedPorts.Add(port.LocalPort);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public async void ResolveConnectionDetails_RestoreCheck(int numServices, bool ha
// We only care about this exception for this UT. ResolveConnectionDetails is large function and ot get to pass cleanly would require a lot longer set up,
// which is not needed for this UT
if (e.Message.StartsWith("Restoration pod is still present for the specified service")) {
Assert.Equal(phase, "Running");
Assert.Equal("Running", phase);
Assert.True(hasRestore);
}
}
Expand Down