Fixes warnings for nullable reference types being used #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eneuman Thanks for your PR! My review of this pull request is that it looks good overall. The changes made are appropriate and address the issue of nullable reference types being used. The changes made to the JsonHelpers.cs, IntOrStringJsonConverter.cs, and IPAddressConverter.cs files are all valid and should help to resolve the issue. My only suggestion would be to add a comment to the code to explain why the changes were made. This would help to provide context for future readers of the code and make it easier to understand why the changes were made. |
hsubramanianaks
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three occurences where nullable reference types where being used but the project had not enabled this feature.
Fixes #252