-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
226 - add ns to env vars when workload ns != service ns #227
Conversation
…into 226-port-namespaces
@microsoft-github-policy-service agree company="Go1" |
@garyburgmann Thanks for your PR! My review of this pull request is as follows: This pull request adds the ability to add namespace to environment variables when the workload namespace is not the same as the service namespace. This is a useful feature as it allows for cross-talk between namespaces. The changes look good and the code is well-structured and easy to read. The tests are also comprehensive and cover all the scenarios. However, I suggest adding a comment to the code to explain why the namespace is being added to the environment variables. This will help other developers understand the purpose of the code and make it easier to maintain in the future. Overall, this is a good pull request and I recommend merging it. |
…into 226-port-namespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @garyburgmann. We will test it and confirm.
Passed on all 3 platforms. |
This PR is to add namespace to the env variable for the services which are in not in workload's namespace and defined via KubernetesLocalProcessConfig.yaml.