Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating logging property and update string manipulation #208

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Updating logging property and update string manipulation #208

merged 3 commits into from
Mar 21, 2023

Conversation

elenavillamil
Copy link
Contributor

We need to update failure reason property name since existing one was suppressed. Also adding UTs and fix function per UTs.

hsubramanianaks
hsubramanianaks approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@elenavillamil elenavillamil merged commit da3ea55 into Azure:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubramanianaks hsubramanianaks hsubramanianaks approved these changes

@Tatsinnit Tatsinnit Awaiting requested review from Tatsinnit Tatsinnit is a code owner

@sabbour sabbour Awaiting requested review from sabbour sabbour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenavillamil @hsubramanianaks