Modified method to have one set of env variables and added UTs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vidya2606 Thanks for your PR! My in-depth review of this pull request is as follows: This pull request looks good overall. The changes made are clear and the code is well-structured. The new UTs are a great addition and should help ensure the code is working as expected. The main issue I see is that the code is not retaining the previous environment variables when creating new ones. This could lead to unexpected behavior and should be addressed. I suggest adding a line of code to retain the previous environment variables when creating new ones. This should ensure that only one set of environment variables is present. |
Tatsinnit
reviewed
Apr 4, 2023
hsubramanianaks
added
e2e testing
hsubramanianaks
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #147
I have Modified the method to add only the new environment variables, the old one's will not be added.
Also added the respective UT's