Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix case sensitivity and update base images for mariner #175

Merged
merged 6 commits into from
Apr 4, 2023
Merged

fix case sensitivity and update base images for mariner #175

merged 6 commits into from
Apr 4, 2023

Conversation

gambtho
Copy link
Contributor

@gambtho gambtho commented Feb 24, 2023 •
edited
Loading

Updating images to use mariner versions - https://learn.microsoft.com/en-us/azure/aks/use-mariner

@gambtho gambtho requested review from a team, Tatsinnit and sabbour as code owners February 24, 2023 17:09
Tatsinnit
Tatsinnit previously approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️☕️ +1, Thank you for adding this and for this PR, looks great, just added some observation, thanks heaps! (I don't quiet know how this multi-step docker files fit together but 100 % agree that we should manually test this)

src/LocalAgent/Dockerfile Outdated Show resolved Hide resolved
samples/ingress/database-api/Dockerfile Outdated Show resolved Hide resolved
src/LocalAgent/Dockerfile Outdated Show resolved Hide resolved
hsubramanianaks
hsubramanianaks previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few suggestions, other than that everything looks good to me.

@gambtho gambtho changed the title WIP - fix case sensitivity and update base images for mariner fix case sensitivity and update base images for mariner Mar 15, 2023
@gambtho gambtho dismissed stale reviews from hsubramanianaks and Tatsinnit via fbc1d2b March 24, 2023 20:55
@hsubramanianaks hsubramanianaks added the e2e testing e2e is in progress label Mar 28, 2023
hsubramanianaks
hsubramanianaks previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and testing team didn't find any issue for a week. @gambtho Thanks for this PR.

@hsubramanianaks hsubramanianaks merged commit e7ac738 into main Apr 4, 2023
@hsubramanianaks hsubramanianaks deleted the thgamble/baseimageupdate branch April 4, 2023 03:03
@hsubramanianaks hsubramanianaks mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubramanianaks hsubramanianaks hsubramanianaks approved these changes

@Tatsinnit Tatsinnit Tatsinnit left review comments

@sabbour sabbour Awaiting requested review from sabbour sabbour is a code owner

Assignees
No one assigned
Labels
e2e testing e2e is in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gambtho @Tatsinnit @hsubramanianaks