Release note for JS FM v2 #1008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
zhenlan,
rossgrambo,
jimmyca15,
linglingye001 and
Copilot
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
releaseNotes/JavaScriptFeatureManagement.md:21
- The phrase 'publish feature evaluation event to Application Insights' should be rephrased to 'publish feature evaluation events to Application Insights' for better clarity.
This hook can be used to publish telemetry. You can call `createTelemetryPublisher` API from `@microsoft/feature-management-applicationinsights-browser` and `@microsoft/feature-management-applicationinsights-node` packages to publish feature evaluation event to Application Insights.
jimmyca15
reviewed
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
releaseNotes/JavaScriptFeatureManagementApplicationInsightsBrowser.md
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Jan 16, 2025
releaseNotes/JavaScriptFeatureManagementApplicationInsightsBrowser.md
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
Jan 16, 2025
jimmyca15
reviewed
Jan 16, 2025
|
|
||
| The new `getVariant` method of `FeatureManager` has been introduced to evaluate the assigned variant based on the variant feature flag configuration and targeting context. [#13](https://github.com/microsoft/FeatureManagement-JavaScript/pull/13) | ||
|
|
||
| * __Telemetry__ |
There was a problem hiding this comment.
Suggested change
| * __Telemetry__ | |
| * __Feature Evaluation Telemetry__ |
I think it might be better to be specific about the fact it's telemetry on feature evaluations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.