Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CancellationToken during refresh operations #281

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Add support for CancellationToken during refresh operations #281

merged 6 commits into from
Oct 19, 2021

Conversation

avanigupta
Copy link
Member

This PR adds a cancellation token to RefreshAsync and TryRefreshAsync methods.
Since the IConfigurationRefresher interface has changed, this is a breaking change. However, users will still be able to call RefreshAsync() and TryRefreshAsync() without any parameter.

Fix #275

@avanigupta avanigupta requested a review from MBSolomon October 19, 2021 20:02
@avanigupta avanigupta force-pushed the avanigupta/cancellationtoken branch from 61322dc to 0c742aa Compare October 19, 2021 20:09
@avanigupta avanigupta merged commit 0e549de into main Oct 19, 2021
@avanigupta avanigupta deleted the avanigupta/cancellationtoken branch October 19, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyca15 jimmyca15 jimmyca15 approved these changes

@zhenlan zhenlan Awaiting requested review from zhenlan

@MBSolomon MBSolomon Awaiting requested review from MBSolomon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CancellationToken support in TryRefreshAsync
2 participants
@avanigupta @jimmyca15