-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing an empty string as the value for labelFilter in AzureAppConfigurationOptions.Select retrieves key-values in all labels. #311
Labels
good first issue
Good for newcomers
Comments
jimmyca15
changed the title
Passing String.Empty as the value for labelFilter in AzureAppConfigurationOptions.Select unexpectedly retrieves key-values in all labels.
Passing an empty string as the value for labelFilter in AzureAppConfigurationOptions.Select retrieves key-values in all labels.
Feb 23, 2022
Also repros with whitespace. |
avanigupta
added a commit
that referenced
this issue
Oct 19, 2022
avanigupta
added a commit
that referenced
this issue
Oct 24, 2022
amerjusupovic
added a commit
that referenced
this issue
Nov 28, 2022
* update keyvault secrets package version to 4.3.0, use TryCreate for validation (#351) * update keyvault package version, use trycreate for validation * use identifier instead of secreturi * naming and syntax fixes * Fix whitespace labelfilter bug (#352) * fix empty label bug * remove redundant null check * Remove select optimization (#358) * removed optimization * remove optimization * fix label filter change * fix preservedefaultquery test * Fix Optional Parameter Bug for AddAzureAppConfiguration (#359) * suppress adapter exceptions * remove unnecessary caught exceptions * remove using statement * Add LabelFilter null check for Feature Flags (#361) Fix #311 * Add .net7 as target framework, build with .net7 (#366) * change target frameworks, build version in script * fix comment to net7 * fix missing .net6 install * fix comment * test remove version for dotnet install * revert dotnet install version changes * update same projects target framework * upgrade to 5.2.0 (#368) Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This unexpected behavior was originally described here.
As shown in this line, the Azure App Configuration provider prevents querying key-values from all labels since it can result in indeterministic configuration sets.
The configuration provider checks if label filter contains the
*
character, but it does not check if label filter is an empty string, which also selects key-values in all labels.Example code:
Expected:
Selects key-values with single label, same as passing null.
Actual:
Selects key-values with all labels
The text was updated successfully, but these errors were encountered: