management group id check #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regex is less strict. See Azure#57
jtracey93
requested changes
May 5, 2023
There was a problem hiding this comment.
Can we also update the tests here: https://github.com/Azure/ALZ-PowerShell-Module/blob/main/src/Tests/Unit/Private/Request-ConfigurationValue.Tests.ps1#L82-L89
jtracey93
reviewed
May 5, 2023
Good catch Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Issue #57
Description
Description of changes:
The current regex does not allow a management group id like iac-alz.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.