Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ALZ Bicep Accelerator #42

Merged
merged 6 commits into from
Apr 13, 2023
Merged

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Apr 5, 2023

Pull Request

Issue

General adjustments for ALZ Bicep Accelerator

Issue #, if available:

Description

Description of changes:

  • Need to adjust the policy assignment param file as switched to the ALZ defaults.
  • Need to switch to orchestration version of management diagnostic setting module param file.
  • Switching custom modules directory to match naming convention of custom parameters directory.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@oZakari oZakari requested a review from Nepomuceno April 6, 2023 04:14
@Nepomuceno Nepomuceno added the minor Minor change that just adds features label Apr 6, 2023
@Nepomuceno
Copy link
Member

This willl not change to use the prerelease version that does have this new files you would need to change the version to use that too.

Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will Requiure us to change the version on the files too.

Copy link
Contributor

@lovelysandwich lovelysandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!

@@ -10,7 +10,7 @@ function New-ALZDirectoryEnvironment {
# Create destination file structure
$gitHubPipeline = Join-Path $alzEnvironmentDestination ".github" "workflows"
$config = Join-Path $alzEnvironmentDestination "config"
$configModules = Join-Path $alzEnvironmentDestination "config" "modules"
$configModules = Join-Path $alzEnvironmentDestination "config" "custom-modules"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how quickly I lose context after a few days away :D This is adopting a directory name change in ALZ-Bicep?

@oZakari oZakari merged commit f1654e4 into Azure:main Apr 13, 2023
@oZakari oZakari deleted the accelerator-updates branch April 14, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor change that just adds features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants