Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: relocate bootstrap modules #105

Merged
merged 35 commits into from
Mar 13, 2024

Conversation

jaredfholgate
Copy link
Member

Pull Request

Issue

Issue #, if available: N/A

Description

This PR is a significant refactor to de-couple bootstrap and starter modules. It moves to a configuration based approach for shared inputs and have many other enhancements to the user experience.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@jaredfholgate
Copy link
Member Author

@oZakari, @luke-taylor and @jtracey93 I think this PR is now ready for review. I have some work left to do on the bootstrap repo in terms of enhancing the documentation for the json, but I believe the PowerShell is now functionally complete and the docs are up to date. It would be great if you could double check that the Bicep behaviour is correct and as expected. Especially when running it as it is run today (i.e. New-ALZEnvironment -o "." -i "bicep" -c "github").

I intend to submit separate documentation PR's to each of the supporting repos to update them to match the new naming and upgrade process, but in the meantime the existing documentation should still work for the new version with the exception of the Bicep upgrade process.

@jaredfholgate
Copy link
Member Author

@oZakari, @luke-taylor and @jtracey93 I think this PR is now ready for review. I have some work left to do on the bootstrap repo in terms of enhancing the documentation for the json, but I believe the PowerShell is now functionally complete and the docs are up to date. It would be great if you could double check that the Bicep behaviour is correct and as expected. Especially when running it as it is run today (i.e. New-ALZEnvironment -o "." -i "bicep" -c "github").

I intend to submit separate documentation PR's to each of the supporting repos to update them to match the new naming and upgrade process, but in the meantime the existing documentation should still work for the new version with the exception of the Bicep upgrade process.

I do appreciate there are a lot of changes to the code here, so difficult to peer review from that perspective, but hopefully an end to end test will be sufficient to show it works as expected.

If you do have any specific questions about the code I can of course answer them.

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jaredfholgate jaredfholgate added the minor Minor change that just adds features label Mar 13, 2024
@jaredfholgate jaredfholgate self-assigned this Mar 13, 2024
@jaredfholgate
Copy link
Member Author

Merging this release to be able to run end to end testing with alpha. Will not publish the full release until e2e tests are passing.

@jaredfholgate jaredfholgate merged commit 6728899 into main Mar 13, 2024
2 checks passed
@jaredfholgate jaredfholgate deleted the enhancement-relocate-bootstrap-modules branch March 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor change that just adds features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants