refactor: Allow option to specify virtual network gateway ip configuration names #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d module (#903) * Fix private dns zone list in policy assignment * Remove unused dns zone ids and update param names * Remove unused dns zone ids and update param names * Update generated docs * Add param to accelerator * Generate Parameter Markdowns [oZakari/1618d0f4] * Fix value for param * Add prefix to dependabot title * Update test values * Updated param table * Generate Parameter Markdowns [oZakari/640a1dbc] * Update logic * Update spacing * Add params to parameter file * Generate Parameter Markdowns [oZakari/0a582834] --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
oZakari
had a problem deploying
to
BicepUpdateDocumentation
GitHub Actions
Failure
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
force-pushed
the
main
branch
4 times, most recently
from
d1792a5 to
a97b298
Compare
oZakari
had a problem deploying
to
BicepUpdateDocumentation
GitHub Actions
Failure
oZakari
requested a deployment
to
BicepUpdateDocumentation
GitHub Actions
Waiting
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
oZakari
requested a deployment
to
BicepUpdateDocumentation
GitHub Actions
Waiting
oZakari
requested a deployment
to
BicepUpdateDocumentation
GitHub Actions
Waiting
oZakari
added
Area: Networking 🌐
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request focuses on enhancing the configuration of virtual network gateways by adding new parameters for IP configuration names. It also includes updates to parameter files to reflect these changes.
Enhancements to IP Configuration:
ipConfigurationNameandipConfigurationActiveActiveNameparameters to multiple configuration objects inhubNetworking-multiRegion.bicepandhubNetworking.bicep. [1] [2] [3] [4] [5] [6]Resource Configuration Updates:
resGatewayandresGatewaySecondaryLocationresources to use the new IP configuration name parameters inhubNetworking-multiRegion.bicepandhubNetworking.bicep. [1] [2] [3] [4] [5] [6]Parameter File Updates:
hubNetworking.parameters.all.json[1] [2]hubNetworking.parameters.az.all.json[1] [2]hubNetworking.parameters.az.multiRegion.all.json[1] [2] [3]hubNetworking.parameters.min.json[1] [2]mc-hubNetworking.parameters.all.json[1] [2]mc-hubNetworking.parameters.min.json[1] [2]Related Issues/Work Items
Closes #920
Related to #863
Breaking Changes
hubNetworking.bicep. However, there is now a parameter to set this value to avoid redeployment of the resource.Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch