Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates to fix Region name now being appended to azFw policy name #914 #915

Merged
merged 4 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ parVirtualWanHubsLock | No | Resource Lock Configuration for Virtual WAN H
parVpnGatewayName | No | VPN Gateway Name.
parExpressRouteGatewayName | No | ExpressRoute Gateway Name.
parAzFirewallName | No | Azure Firewall Name.
parAzFirewallPoliciesName | No | Azure Firewall Policies Name.
parAzFirewallPolicyDeploymentStyle | No | The deployment style of the Azure Firewall Policy. Either one shared firewall policy (`SharedGlobal`) or one policy per region (`PerRegion`), defaults to `SharedGlobal`.
parAzFirewallPoliciesName | No | Azure Firewall Policies Name. This is used to automatically generate a name for the Azure Firewall Policy following concat of the pattern `parAzFirewallPoliciesName-hub.parHubLocation` if you want to provide a true custom name then specify a value in each object in the array of `parVirtualWanHubs.parAzFirewallPolicyCustomName`.
parAzFirewallPoliciesAutoLearn | No | The operation mode for automatically learning private ranges to not be SNAT.
parAzFirewallPoliciesPrivateRanges | No | Private IP addresses/IP ranges to which traffic will not be SNAT.
parAzureFirewallLock | No | Resource Lock Configuration for Azure Firewall. - `kind` - The lock settings of the service which can be CanNotDelete, ReadOnly, or None. - `notes` - Notes about this lock.
Expand Down Expand Up @@ -192,11 +193,19 @@ Azure Firewall Name.

- Default value: `[format('{0}-fw', parameters('parCompanyPrefix'))]`

### parAzFirewallPolicyDeploymentStyle

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

The deployment style of the Azure Firewall Policy. Either one shared firewall policy (`SharedGlobal`) or one policy per region (`PerRegion`), defaults to `SharedGlobal`.

- Default value: `SharedGlobal`

### parAzFirewallPoliciesName

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Azure Firewall Policies Name.
Azure Firewall Policies Name. This is used to automatically generate a name for the Azure Firewall Policy following concat of the pattern `parAzFirewallPoliciesName-hub.parHubLocation` if you want to provide a true custom name then specify a value in each object in the array of `parVirtualWanHubs.parAzFirewallPolicyCustomName`.

- Default value: `[format('{0}-azfwpolicy', parameters('parCompanyPrefix'))]`

Expand Down Expand Up @@ -430,6 +439,9 @@ outAzFwPrivateIps | array |
"parAzFirewallName": {
"value": "[format('{0}-fw', parameters('parCompanyPrefix'))]"
},
"parAzFirewallPolicyDeploymentStyle": {
"value": "SharedGlobal"
},
"parAzFirewallPoliciesName": {
"value": "[format('{0}-azfwpolicy', parameters('parCompanyPrefix'))]"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
"parAzFirewallPoliciesName": {
"value": "alz-azfwpolicy"
},
"parAzFirewallPolicyDeploymentStyle": {
"value": "SharedGlobal"
},
"parVirtualWanHubs": {
"value": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
"parAzFirewallPoliciesName": {
"value": "alz-azfwpolicy"
},
"parAzFirewallPolicyDeploymentStyle": {
"value": "SharedGlobal"
},
"parVirtualWanHubs": {
"value": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
"parAzFirewallPoliciesName": {
"value": "alz-azfwpolicy"
},
"parAzFirewallPolicyDeploymentStyle": {
"value": "PerRegion"
},
"parVirtualWanHubs": {
"value": [
{
Expand Down Expand Up @@ -81,7 +84,7 @@
"value": 1
},
"parDdosEnabled": {
"value": false
"value": true
},
"parDdosPlanName": {
"value": "alz-ddos-plan"
Expand Down
Loading
Loading