Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename private DNS zone privatelink.dp.kubernetesconfiguration.azure.com #814

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

baartch
Copy link
Contributor

@baartch baartch commented Jul 22, 2024

Overview/Summary

Regarding the documentation, the name of the private DNS zone is wrong:
https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns#hybrid--multicloud

The documentation was wrong too and has been fixed Sep 2023:
https://github.com/MicrosoftDocs/azure-docs/issues/115266#issuecomment-1739208876

Related Issues/Work Items

This PR fixes/adds/changes/removes

  1. Insert dp. in all occurances of privatelink.kubernetesconfiguration.azure.com. This results in privatelink.dp.kubernetesconfiguration.azure.com.
    I changed all occurances except the ones in generateddocs. I hope this is correct.

Breaking Changes

The private DNS zone has to be recreated.

Testing Evidence

image

As part of this Pull Request I have

@oZakari oZakari self-assigned this Jul 22, 2024
@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working labels Jul 22, 2024
oZakari
oZakari previously approved these changes Jul 23, 2024
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for catching this and creating a PR, much appreciated!

I update the docs as the workflow to generate them automatically failed due to 403. Just a note for future PRs, but the forks inherit branch protections so recommend using a branch other then main for future PRs. Or you can also just generate them locally using guidance here as well: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files

@oZakari oZakari closed this Jul 23, 2024
@oZakari oZakari reopened this Jul 23, 2024
@oZakari
Copy link
Contributor

oZakari commented Jul 23, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari merged commit cfa6355 into Azure:main Jul 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants