Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Several hygiene fixes and/or cleanup #809

Merged
merged 4 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
<!-- Thank you for submitting a Pull Request. Please fill out the template below.-->
# Overview/Summary

<!--
Replace this with a brief description of what this Pull Request fixes, changes, etc.
-->

## Related Issues/Work Items

<!--
- To associate a GitHub Issue, use a [key word](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) preceded with the GitHub issue number.
- To associate an ADO Work Item (internal Microsoft team member), use the key word `AB#` succeeded with the [ADO Work Item ID](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword).
-->

## This PR fixes/adds/changes/removes

<!--
1. *Replace me*
2. *Replace me*
3. *Replace me*
-->

### Breaking Changes

<!--
1. *Replace me*
2. *Replace me*
-->

## Testing Evidence

Expand Down
64 changes: 32 additions & 32 deletions .github/policies/resourceManagement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ configuration:
- isIssue
- isOpen
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
- noActivitySince:
days: 3
actions:
Expand All @@ -31,14 +31,14 @@ configuration:
- isIssue
- isOpen
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
- noActivitySince:
days: 4
- isNotLabeledWith:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
actions:
- addLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
- addReply:
reply: This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
- description:
Expand All @@ -49,7 +49,7 @@ configuration:
- isIssue
- isOpen
- hasLabel:
label: 'Resolution: Duplicate'
label: 'Type: Duplicate :palms_up_together:'
- noActivitySince:
days: 1
actions:
Expand All @@ -64,9 +64,9 @@ configuration:
- isPullRequest
- isOpen
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
- noActivitySince:
days: 7
actions:
Expand All @@ -79,14 +79,14 @@ configuration:
- isPullRequest
- isOpen
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
- noActivitySince:
days: 7
- isNotLabeledWith:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
actions:
- addLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
- addReply:
reply: This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **7 days**. It will be closed if no further activity occurs **within 7 days of this comment**.
eventResponderTasks:
Expand All @@ -97,38 +97,38 @@ configuration:
- isActivitySender:
issueAuthor: True
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
- isOpen
then:
- addLabel:
label: 'Needs: Attention :wave:'
- removeLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
description:
- if:
- payloadType: Issues
- not:
isAction:
action: Closed
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
then:
- removeLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
description:
- if:
- payloadType: Issue_Comment
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
then:
- removeLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
description:
- if:
- payloadType: Pull_Request
then:
- inPrLabel:
label: 'Status: In PR'
label: 'Status: In PR :point_right:'
description:
- if:
- payloadType: Pull_Request_Review
Expand All @@ -138,7 +138,7 @@ configuration:
reviewState: Changes_requested
then:
- addLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
description:
- if:
- payloadType: Pull_Request
Expand All @@ -148,57 +148,57 @@ configuration:
isAction:
action: Closed
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
then:
- removeLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
description:
- if:
- payloadType: Issue_Comment
- isActivitySender:
issueAuthor: True
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
then:
- removeLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
description:
- if:
- payloadType: Pull_Request_Review
- isActivitySender:
issueAuthor: True
- hasLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
then:
- removeLabel:
label: 'Needs: Author Feedback'
label: 'Needs: Author Feedback :ear:'
description:
- if:
- payloadType: Pull_Request
- not:
isAction:
action: Closed
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
then:
- removeLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
description:
- if:
- payloadType: Issue_Comment
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
then:
- removeLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
description:
- if:
- payloadType: Pull_Request_Review
- hasLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
then:
- removeLabel:
label: 'Status: No Recent Activity'
label: 'Status: No Recent Activity :zzz:'
description:
- if:
- payloadType: Issue_Comment
Expand Down Expand Up @@ -241,7 +241,7 @@ configuration:
- if:
- payloadType: Pull_Request
- labelAdded:
label: 'Needs: upstream policy changes :up:'
label: 'Needs: Upstream Policy Changes :arrows_clockwise:'
then:
- addReply:
reply: >-
Expand Down
8 changes: 4 additions & 4 deletions version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "0.17.2",
"gitTag": "v0.17.2",
"releaseNotes": "https://github.com/Azure/ALZ-Bicep/releases/tag/v0.17.2",
"releaseDateTimeUTC": "20240227T145935000Z"
"version": "0.18.0",
"gitTag": "v0.18.0",
"releaseNotes": "https://github.com/Azure/ALZ-Bicep/releases/tag/v0.18.0",
"releaseDateTimeUTC": "20240709T0222079056Z"
}