-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Fix deploymentnames in pipeline-scripts to max 64 char #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @picccard! Before I merge, I'll update the readme's with this change as well. |
10 tasks
oZakari
previously approved these changes
Jul 9, 2024
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for catching that extra parenthesis @picccard 😄 |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Bug in the pipeline-scripts causes the the date to be limited to 64 chars, instead of limiting the entire deploymentname to be max 64 chars. This PR fixes this.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch