Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix deploymentnames in pipeline-scripts to max 64 char #801

Merged
merged 16 commits into from
Jul 9, 2024

Conversation

picccard
Copy link
Contributor

Overview/Summary

Bug in the pipeline-scripts causes the the date to be limited to 64 chars, instead of limiting the entire deploymentname to be max 64 chars. This PR fixes this.

As part of this Pull Request I have

@oZakari
Copy link
Contributor

oZakari commented Jul 2, 2024

Thanks @picccard! Before I merge, I'll update the readme's with this change as well.

@oZakari oZakari self-assigned this Jul 2, 2024
@oZakari oZakari added the Type: Bug 🪲 Something isn't working label Jul 2, 2024
oZakari
oZakari previously approved these changes Jul 9, 2024
@oZakari
Copy link
Contributor

oZakari commented Jul 9, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor

oZakari commented Jul 9, 2024

Thanks for catching that extra parenthesis @picccard 😄

@oZakari
Copy link
Contributor

oZakari commented Jul 9, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari merged commit 038090c into Azure:main Jul 9, 2024
8 checks passed
@picccard picccard deleted the update-deploymentscripts branch July 10, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants