Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / ALZ-Bicep Public

Notifications You must be signed in to change notification settings
Fork 517
Star 774

Code
Issues 19
Pull requests 6
Actions
Projects 2
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Remove secret references for login #793

Merged

oZakari merged 9 commits into Azure:main from oZakari:oidc-login

Jul 16, 2024

Merged

Enhancement: Remove secret references for login #793

oZakari merged 9 commits into Azure:main from oZakari:oidc-login

Jul 16, 2024

Conversation 15 Commits 9 Checks 8 Files changed

Conversation

Copy link

Contributor

oZakari commented Jun 14, 2024 •

edited

Loading

Overview/Summary

Transitioning all applicable workflows to OIDC login with updated service connection. It also fixes bug referenced in ALZ-PowerShell module with outdated login action.

Closes - AB#36135
Closes - GitHub Actions fail during OIDC login using azure/login@v1 in combination with Az.Accounts/3.0.0 ALZ-PowerShell-Module#118

This PR fixes/adds/changes/removes

Removes secrets for workflow logins which have been replaced with OIDC

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

Read the Contribution Guide and ensured this PR is compliant with the guide
Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
Checked for duplicate Pull Requests
Associated it with relevant GitHub Issues
(ALZ Bicep Core Team Only) Associated it with relevant ADO Items
Ensured my code/branch is up-to-date with the latest changes in the main branch
Performed testing and provided evidence.
Updated one or more of the following tests (if required)
Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
If relevant, created or updated Code Tours here

Sorry, something went wrong.

All reactions


          Remove secret references for login

165c6b5

oZakari added the Type: Hygiene 🧹 Things related to testing, issue triage etc. label

Copy link

Contributor Author

oZakari commented Jun 14, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jun 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

oZakari added 2 commits

July 11, 2024 21:22


          Merge branch 'main' of https://github.com/Azure/ALZ-Bicep into oidc-l…

bb8676f

…ogin


          Login to Azure CLI

73ddc48

Copy link

Contributor Author

oZakari commented Jul 12, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.


          Testing login

f55dcdb

Copy link

Contributor Author

oZakari commented Jul 12, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.


          Fix token misspelling

6ad0149

Copy link

Contributor Author

oZakari commented Jul 12, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.


          Update remaining pipeline files

f73f710

Copy link

Contributor Author

oZakari commented Jul 12, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.


          Update display names of tasks

e508076

oZakari assigned Springstone

Copy link

Contributor Author

oZakari commented Jul 12, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.


          Update azure/login github action to v2

ab58799

Springstone approved these changes

View reviewed changes

Copy link

Member

Springstone left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can't verify the secrets, but assume they exist in ADO.

Sorry, something went wrong.

All reactions


          Merge branch 'main' into oidc-login

a9e45e9

Copy link

Contributor Author

oZakari commented Jul 16, 2024

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Jul 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

oZakari merged commit bf7a19b into Azure:main

8 checks passed

oZakari deleted the oidc-login branch

July 16, 2024 21:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Springstone Springstone approved these changes

Assignees

Labels

Type: Hygiene 🧹

Things related to testing, issue triage etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.