Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update Issue #1 Guidance #758

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Documentation: Update Issue #1 Guidance #758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd93a9
Fix version references for known issue #1
oZakari Apr 10, 2024
ce5486c
Update to match modules for known issue 1
oZakari Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs/wiki/KnownIssues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,26 @@ This page lists the known issues and limitations currently present in ALZ-Bicep.

```yaml
- task: AzurePowerShell@5
displayName: "Logging and Sentinel Deployment"
displayName: "Logging and Sentinel Resource Group Deployment"
inputs:
azureSubscription: ${{ variables.SERVICE_CONNECTION_NAME }}
azurePowerShellVersion: "11.3.0"
azurePowerShellVersion: OtherVersion
preferredAzurePowerShellVersion: 11.5.0
pwsh: true
ScriptType: "InlineScript"
Inline: |
.\pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1
.\pipeline-scripts\Deploy-ALZLoggingAndSentinelResourceGroup.ps1
```

GitHub Actions Workaround:

```yaml
- name: "Logging and Sentinel Deployment"
- name: "Logging and Sentinel Resource Group Deployment"
uses: azure/powershell@v1
with:
inlineScript: |
.\pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1
azPSVersion: "11.3.0"
.\pipeline-scripts\Deploy-ALZLoggingAndSentinelResourceGroup.ps1
azPSVersion: "11.5.0"
```

- **Status:** As our team doesn't directly own the impacted module or have control over the agents/runners, we aim to enhance flexibility to assist with such issues in the future. To achieve this, we plan to introduce a variable in the .env file, enabling version control without the need for individual additions.
Expand Down