Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Enforce-GR-KeyVault policy assignment from platform management to platform scope #752

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

alperkar
Copy link
Contributor

@alperkar alperkar commented Apr 1, 2024

Overview/Summary

According to https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Policies#platform Enforce-GR-KeyVault policy assignment should be scoped to Platform management group. However, it was being assigned to the management management group. This fixes that.

This PR fixes/adds/changes/removes

Changes Enforce-GR-KeyVault policy assignment from Management to Platform management group

Breaking Changes

none

Testing Evidence

not tested

As part of this Pull Request I have

@alperkar
Copy link
Contributor Author

alperkar commented Apr 1, 2024

Fixes #751

@alperkar
Copy link
Contributor Author

alperkar commented Apr 1, 2024

@microsoft-github-policy-service agree

@oZakari
Copy link
Contributor

oZakari commented Apr 8, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari changed the title Change Enforce-GR-KeyVault policy assignment from Management to IntRoot management group Change Enforce-GR-KeyVault policy assignment from platform management to platform scope Apr 8, 2024
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks much @achechen!

@oZakari oZakari added Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working labels Apr 8, 2024
@oZakari oZakari merged commit 5e23e06 into Azure:main Apr 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants