Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign additional built-in Sovereign landing zone policy initiatives #718

Merged
merged 23 commits into from
Feb 5, 2024

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Jan 29, 2024

Overview/Summary

AB#32559

Assign additional built-in Sovereign landing zone policy initiatives for the ALZ Default Policy Assignments Module.

This PR fixes/adds/changes/removes

  1. Assign below initiatives in ALZ Bicep, optionally, disabled by default
    [Preview]: Sovereignty Baseline - Global Policies - c1cbff38-87c0-4b9f-9f70-035c7a3b5523 (azadvertizer.net) to the Intermediate Root Management Group
    [Preview]: Sovereignty Baseline - Confidential Policies - 03de05a4-c324-4ccd-882f-a814ea8ab9ea (azadvertizer.net) to the confidential-corp & confidential-online Management Groups, if deployed/exist

Breaking Changes

  1. None

Testing Evidence

Tested deployment with parLandingZoneMgConfidentialEnable as well as with changing out specific params within the user defined types.

Confidential Corp
image

Confidential Online
image

Int-Root
image

As part of this Pull Request I have

@oZakari
Copy link
Contributor Author

oZakari commented Jan 30, 2024

/azp run validateazcloud

@oZakari oZakari marked this pull request as ready for review January 30, 2024 01:06
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari requested a review from jtracey93 January 30, 2024 01:07
@oZakari oZakari changed the title Ado 32559 Assign additional built-in Sovereign landing zone policy initiatives Jan 30, 2024
@oZakari oZakari added enhancement Area: Policy 📝 Issues / PR's related to Policy labels Jan 31, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Feb 1, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor Author

oZakari commented Feb 1, 2024

@jtracey93 Added in the logic to use the deployment().location and tested.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks please @oZakari

Also tagging @vedagudipati @azure-lm @KevinRabun for a review before we merge

oZakari and others added 3 commits February 2, 2024 14:06
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
oZakari and others added 6 commits February 2, 2024 14:07
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…DefaultPolicyAssignments.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Feel free to merge at end of day if nothing from @azure-lm, @KevinRabun or @vedagudipati 👍

Great work @oZakari

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 2023eac into Azure:main Feb 5, 2024
10 checks passed
@oZakari oZakari deleted the ado-32559 branch February 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants