Bug: Fix deployment toggle to hub-spoke by adding AzBastionEnabled boolean to resBastionSubnetRef

[FallenHoot]

Overview/Summary

Was notified by @jamiepla1 of an issue dealing with hubNetworking.parameters.all.json file in the infra-as-code\bicep\modules\hubNetworking\parameters\ directory when updating parSubnets.value.name = AzureBastionSubnet. Some customers might opt-out of keeping AzureBastionSubnet if parAzBastionEnabled = false, removing it from parSubnets still gives you errors.

The finding was the missing toggle located in hubNetworking.bicep file in the infra-as-code/bicep/modules/hubNetworking directory to update the resBastionSubnetRef resource declaration.

This PR fixes/adds/changes/removes

Adding if (parAzBastionEnabled) to infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep: Updated the resBastionSubnetRef resource declaration. (hubNetworking.bicep: resBastionSubnetRef)

Allows you to remove AzureBastionSubnet from hubNetworking.parameters.all.json file in the infra-as-code\bicep\modules\hubNetworking\parameters\ directory when updating parSubnets.value.name = AzureBastionSubnet

Breaking Changes

N/A

Testing Evidence

Before Fix
The deployment 'alz-Hub-and-SpokeDeploy-20231206T1512101164Z'
| failed with error(s). Showing 1 out of 1 error(s). Status Message:
| Resource
| /subscriptions/88888888-8888-8888-8888-888888888888/resourceGroups/rg-alz-connectivity/providers/Microsoft.Network/virtualNetworks/alz-hub-norwayeast/subnets/AzureBastionSubnet not found. (Code: NotFound)

After Fix

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• [] Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• [] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• [] If relevant, created or updated Code Tours here

[oZakari]

Thanks @FallenHoot!