Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing parTags to the private zone links #698

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Added missing parTags to the private zone links #698

merged 1 commit into from
Dec 7, 2023

Conversation

sergey-netdev
Copy link
Contributor

Overview/Summary

Tags are not passed to the private dns link modules which breaks deployment when there are policies in place requiring a tag, see #697

This PR fixes/adds/changes/removes

Adds parTags parameter to resVirtualNetworkLink and resVirtualNetworkLinkFailover

Breaking Changes

None

Testing Evidence

  1. Deploy "Require a tag and its value on resources" policy to require Environment tag.
  2. Deploy the hub module.
  3. The deployment fails, sometimes with weird error like "FirewallPolicyUpdateFailed: Put on Firewall Policy afwp-poc-hub-euw Failed with 1 faulted referenced firewalls", sometimes with "RequestDisallowedByPolicy: Resource 'link-vqlscyvvqtsm4' was disallowed by policy." depending on the state.
  4. Apply the fix and redeploy -> the deployment succeeds.

@sergey-netdev sergey-netdev mentioned this pull request Dec 6, 2023
Closed
2 tasks
@oZakari
Copy link
Contributor

oZakari commented Dec 7, 2023

/azp run validateazcloud

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

oZakari
oZakari approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sergey-netdev!

@oZakari oZakari merged commit dad46f4 into Azure:main Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-netdev @oZakari