Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate availability zone param file for hubNetworking module #690

Merged

Conversation

bobanda87
Copy link
Contributor

Overview/Summary

Virtual network gateways deployed with VPN gateway type should support multi availability zones, based on the psrule suggestions (ref. https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.VNG.VPNAvailabilityZoneSKU/ and https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.PublicIP.AvailabilityZone/)

This PR fixes/adds/changes/removes

  1. SKU for virtual network gateways with VPN gateway type
  2. Vpn Gateway availability zones support
  3. Express Route Gateway availability zones support
  4. Firewall availability zones support

Breaking Changes

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@bobanda87 bobanda87 force-pushed the patch-availability-zones-support-hubnetworking branch from 4dd3929 to 81146e0 Compare November 22, 2023 21:54
@bobanda87 bobanda87 force-pushed the patch-availability-zones-support-hubnetworking branch from 81146e0 to 75bf2d8 Compare November 23, 2023 12:25
@oZakari oZakari changed the title Incorporate availability zone support for hubNetworking module Incorporate availability zone param file for hubNetworking module Nov 29, 2023
@oZakari
Copy link
Contributor

oZakari commented Nov 29, 2023

Thanks for getting this PR in, @bobanda87! I just updated the SKU for the Express Route gateway and added some clarifying documentation to the readme.md for the module.

Once you agree to the Contributor License Agreement, I can go ahead an merge your PR. Have a good week!

@oZakari oZakari self-assigned this Nov 29, 2023
@bobanda87
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback labels Nov 29, 2023
@oZakari oZakari merged commit ab5549b into Azure:main Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention 👋 Needs attention from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants