Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation of ALZ Powershell module for policy scripts #679

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Nov 10, 2023

Overview/Summary

Now that the Edit-LineEndings function has been moved to the ALZ PowerShell Module, I have adjusted the Invoke-PolicytoBicep scripts to prompt users to install the module.

#678

This PR fixes/adds/changes/removes

  1. Adds the installation of the ALZ-PowerShell-Module to the Invoke-PolicytoBicep.ps1 script.
  2. Adds the installation of the ALZ-PowerShell-Module to the Invoke-PolicytoBicep-China.ps1 script and cleans up local installation of ALZ.Tools references

Breaking Changes

  1. None

Testing Evidence

Performs test to ensure it prompts the user prior to installing and that it wouldn't prompt user again after the initial installation.

As part of this Pull Request I have

@oZakari oZakari requested a review from a team as a code owner November 10, 2023 06:11
@oZakari oZakari requested a review from jtracey93 November 10, 2023 06:20
@jtracey93
Copy link
Collaborator

@oZakari these scripts are invoked by https://github.com/Azure/ALZ-Bicep/blob/main/.github/workflows/update-policy.yml & https://github.com/Azure/ALZ-Bicep/blob/main/.github/workflows/update-policy-china.yml, do we need to install the ALZ module as part of these workflows? Or is that already covered?

@oZakari
Copy link
Contributor Author

oZakari commented Nov 13, 2023

Thanks @jtracey93 for linking those, I've updated the MC workflow and added some logging as well.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of tweaks

.github/scripts/Invoke-PolicyToBicep-China.ps1 Outdated Show resolved Hide resolved
.github/scripts/Invoke-PolicyToBicep.ps1 Outdated Show resolved Hide resolved
oZakari and others added 2 commits November 20, 2023 11:24
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@oZakari oZakari merged commit 1c6ba00 into Azure:main Nov 20, 2023
4 checks passed
@oZakari oZakari deleted the policy-script-doc-updates branch November 21, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants