Add fallback vnet for failover dns resolving.

[Acenl12]

Overview/Summary

Add fallback vnet for failover dns resolving.

[Acenl12]

@microsoft-github-policy-service agree

[jtracey93]

Thanks @Acenl12 for the PR.

A few comments for review please

[jtracey93]

Thanks for the work here @Acenl12.

Could you please review the comments and suggestion I have left in this review and also the below points:

1. Should we expose this new parameter in the hubNetworking.bicep and vwanConnectivity.bicep modules? I think we should, if so please add this parameter there also and update docs, parameter files etc.
2. Can you run the script detailed here: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files to update the parameter docs as the workflow is failing.

Thanks

[Acenl12]

Thanks for the work here @Acenl12.
Could you please review the comments and suggestion I have left in this review and also the below points:

1. Should we expose this new parameter in the hubNetworking.bicep and vwanConnectivity.bicep modules? I think we should, if so please add this parameter there also and update docs, parameter files etc.
2. Can you run the script detailed here: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files to update the parameter docs as the workflow is failing.

Thanks

I have add the markdown in my branch, hopefully that will be automatically updates in the pull request

Why do you think it's a good idea that it also there? I can't judge. I think modules should kept solo with as less references as possible, if somebody only wants to run a certain module. I generated the markdown hopefully that's sufficient now.@jtracey93

[jtracey93]

Thanks for the work here @Acenl12.
Could you please review the comments and suggestion I have left in this review and also the below points:

1. Should we expose this new parameter in the hubNetworking.bicep and vwanConnectivity.bicep modules? I think we should, if so please add this parameter there also and update docs, parameter files etc.
2. Can you run the script detailed here: Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files to update the parameter docs as the workflow is failing.

Thanks

I have add the markdown in my branch, hopefully that will be automatically updates in the pull request

Why do you think it's a good idea that it also there? I can't judge. I think modules should kept solo with as less references as possible, if somebody only wants to run a certain module. I generated the markdown hopefully that's sufficient now.@jtracey93

Thanks @Acenl12, as for point 1, the primary consumption method for the Private DNS Zones module is the Hub Networking and VWAN Bicep modules as per the deployment flow: https://github.com/Azure/ALZ-Bicep/wiki/DeploymentFlow

So if we can add the parameters to these modules and pass them into the Private DNS Zones module you have updated here, we allow anyone, no matter how they are consuming/using the modules to get access to the new feature you've added in this PR.

Please make the change requested and expose in these modules 👍

Thanks

[Acenl12]

I have updated both modules and generated markdown after that.

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

LGTM, thanks @Acenl12