Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS & Fix Sentinel Simplified Pricing #582

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jul 21, 2023

Overview/Summary

Add CODEOWNERS & Fix Sentinel Simplified Pricing

This PR fixes/adds/changes/removes

  1. Add CODEOWNERS for accelerator/** flexibility in PR approvals
  2. Add capability to handle new Sentinel simplified pricing model released in July 2023, as explained here: https://learn.microsoft.com/azure/sentinel/enroll-simplified-pricing-tier?tabs=microsoft-sentinel#change-pricing-tier-to-simplified
  3. Fixes [Sentinel] - Error occurs when deploying Sentinel in a new Azure tenant  #581

Breaking Changes

  1. Technically not a "true" breaking change - but these changes by default will set/convert the pricing tier on sentinel to the new simplified pricing tier (https://learn.microsoft.com/azure/sentinel/enroll-simplified-pricing-tier?tabs=microsoft-sentinel#change-pricing-tier-to-simplified) for existing deployments of the solution.
    • You can stop this by setting the Boolean parameter for parUseSentinelClassicPricingTiers for the logging.bicep module to true

Testing Evidence

With params set to:

  • parUseSentinelClassicPricingTiers = true

image

With params set to:

  • parUseSentinelClassicPricingTiers = false (default for module)

image

Note: No removal of sku property

image

As part of this Pull Request I have

@jtracey93 jtracey93 closed this Jul 21, 2023
@jtracey93 jtracey93 reopened this Jul 21, 2023
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 requested a review from oZakari July 21, 2023 17:35
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jtracey93 jtracey93 merged commit ccf3ef8 into main Jul 21, 2023
@jtracey93 jtracey93 deleted the fix/sentinel-pricing branch July 21, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentinel] - Error occurs when deploying Sentinel in a new Azure tenant
2 participants