Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Use of Bicep Linter & Simplify Config #568

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jun 23, 2023

Overview/Summary

Enhance Use of Bicep Linter & Simplify Config

This PR fixes/adds/changes/removes

  1. Moves away from separate bicepconfig.json per module and instead moves to centralised bicepconfig.json for all modules apart from networking related modules as some differences are required there from the central linter rules
  2. Fixes Daily Bicep Build & Lint Worklfow Failed  #567 - updated API version as well as mmaking linter changes
  3. Updated contribution guide
  4. Fixed some linter rules where we were using json(null) and can just use null instead

Breaking Changes

None

Testing Evidence

Linting and tests will suffice

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jun 23, 2023
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels Jun 23, 2023
@jtracey93 jtracey93 marked this pull request as ready for review June 23, 2023 11:01
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 requested a review from oZakari June 23, 2023 14:36
oZakari
oZakari previously approved these changes Jun 23, 2023
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oZakari oZakari self-requested a review June 23, 2023 16:44
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily Bicep Build & Lint Worklfow Failed
2 participants