Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved control of PrivateDnsZones beeing deployed #543

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

picccard
Copy link
Contributor

@picccard picccard commented May 27, 2023

Overview/Summary

When hubNetworking.parameters.all.json or vwanConnectivity.parameters.all.json contains no Zone for Azure Backup, the module will deploy a zone for the service anyway, aslong as there exists one in the deployment-location.

This PR allows the consumer to skip the Azure-Backup-Zone lookup and only deploy the zones provided in parPrivateDnsZones.

...
"parPrivateDnsZones": {
  "value": [
    "privatelink.blob.core.windows.net",
    "privatelink.file.core.windows.net"
  ]
},
...

This PR fixes/adds/changes/removes

  1. Adds a new bool param parPrivateDnsZoneAutoMergeAzureBackupZone in modules privateDnsZone, hubNetworking and vwanConnectivity

Breaking Changes

None, it is optional to make use of this.

Testing Evidence

Setting the flag to false prevents the auto merged zone for azure backup from beeing deployed.
image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 27, 2023
@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels May 30, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit bc38606 into Azure:main Jun 9, 2023
@picccard picccard deleted the ignore-mergeazbackupdnszone branch June 9, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants