Option for subnet delegations #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jtracey93
added
enhancement
and removed
Needs: Triage 🔍
|
Ok, removed the new subnets and left only the functionality to delegate subnets. There is not any doc explaining how-to delegate subnets yet, but I don't see any good place to put it. |
|
@Piccard could you resolve the test failures please 👍 |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Delegating a subnet to an azure service is possible in terraform, but not yet possible in the bicep version of ALZ.
The feature is not well documented though: Azure/terraform-azurerm-caf-enterprise-scale#711
This PR fixes/adds/changes/removes
1.1 Subnets that should not have delegations can skip/ignore the use of this property
1.2 The vnet resource api accepts the delegation object to be a list, but my attempt to delegate for two services failed. I've never successfully delegated a subnet to two services, that might cause conflicts if both azure services deploy stuff into the subnet on the same IP(?)
Breaking Changes
None
Testing Evidence
-WhatIf deployment of two new subnets with delegation:
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch