-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter descriptions and typos #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picccard
changed the title
Fix typos and descriptions in hubNetworking parameters
Update parameter descriptions and typos
May 14, 2023
jtracey93
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @picccard
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
May 16, 2023
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
All hubNetworking.parameters.x.json comes with an ipRange for the AzureFirewallManagementSubnet (10.10.253.0/24) that is out of range for the hub-vNet (10.20.0.0/16).
PR also include some general parameter description hygiene, removal of default value as reported in #410
This PR fixes/adds/changes/removes
3.1. Kept descriptions with
Default: Empty String
&Default: Empty Array
&Default: Empty Object
as these empty values does not show up in the generated docs.3.2
Breaking Changes
None
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch