Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter descriptions and typos #524

Merged
merged 14 commits into from
May 16, 2023

Conversation

picccard
Copy link
Contributor

@picccard picccard commented May 11, 2023

Overview/Summary

All hubNetworking.parameters.x.json comes with an ipRange for the AzureFirewallManagementSubnet (10.10.253.0/24) that is out of range for the hub-vNet (10.20.0.0/16).

PR also include some general parameter description hygiene, removal of default value as reported in #410

This PR fixes/adds/changes/removes

  1. Fixes faulty default ipRange for AzureFirewallManagementSubnet in parameter files for hubNetworking
  2. Updates the description for some of the parameters in hubNetworking
  3. Removes some default value from parameter description text
    3.1. Kept descriptions with Default: Empty String & Default: Empty Array & Default: Empty Object as these empty values does not show up in the generated docs.
    3.2 image

Breaking Changes

None

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 11, 2023
@picccard picccard changed the title Fix typos and descriptions in hubNetworking parameters Update parameter descriptions and typos May 14, 2023
@jtracey93 jtracey93 linked an issue May 16, 2023 that may be closed by this pull request
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @picccard

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added hygiene and removed Needs: Triage 🔍 Needs triaging by the team labels May 16, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 233fc4e into Azure:main May 16, 2023
@picccard picccard deleted the fix-hubparamtypos branch May 16, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DevOps Pipeline Step failed: "Az CLI Deploy Hub Network"
2 participants