Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #517 by making the deployment name for the recently added module unique on the zones resource ID #518

Merged
merged 1 commit into from
May 3, 2023

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Fixes #517 by making the deployment name for the recently added module unique on the zones resource ID

This PR fixes/adds/changes/removes

  1. Fixes Facing issues with new feature PrivateDnsZoneLinkToSpoke #517 by making the deployment name for the recently added module unique on the zones resource ID

Breaking Changes

None

Testing Evidence

Validates locally fine with multiple zones in the parameter array

As part of this Pull Request I have

@jtracey93 jtracey93 requested a review from 4pplied May 3, 2023 09:58
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 3, 2023
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label May 3, 2023
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@4pplied 4pplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit ad33c27 into Azure:main May 3, 2023
@jtracey93 jtracey93 deleted the fix-517 branch May 3, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facing issues with new feature PrivateDnsZoneLinkToSpoke
2 participants