-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to set NSG and UDR on subnets in hub-vnet #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picccard
changed the title
add option to associate routetable with hub-subnet
add option to set NSG and UDR on subnets in hub-vnet
May 1, 2023
jtracey93
added
Area: Networking
and removed
Needs: Triage 🔍
Needs triaging by the team
labels
May 3, 2023
@jtracey93 conflicts have been resolved |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR fixes/adds/changes/removes
This covers the issues in #512. This adds the option to set UDR and NSG on subnets in the hub-network, through the parameterfile for hubNetworking.
Breaking Changes
Testing Evidence
Works as intended, however
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch