Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set NSG and UDR on subnets in hub-vnet #513

Merged
merged 16 commits into from
May 3, 2023

Conversation

picccard
Copy link
Contributor

@picccard picccard commented Apr 29, 2023

Overview/Summary

This PR fixes/adds/changes/removes

This covers the issues in #512. This adds the option to set UDR and NSG on subnets in the hub-network, through the parameterfile for hubNetworking.

Breaking Changes

  1. None, as both new features are optional.

Testing Evidence

Works as intended, however

  1. Setting setting a nsg for the AzureBastionSubnet in the parSubnets parameter will have no effect.
  2. The AzureBastionSubnet is hardcoded to use the nsg created by the module itself

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 29, 2023
@picccard picccard changed the title add option to associate routetable with hub-subnet add option to set NSG and UDR on subnets in hub-vnet May 1, 2023
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels May 3, 2023
@jtracey93
Copy link
Collaborator

@picccard thanks for your work here, are you able to pull in the latest from main and resolve the merge conflicts caused by #510 (as planned)

If you are able to get this in today it will likely make the v0.14.0 release this evening :)

@picccard
Copy link
Contributor Author

picccard commented May 3, 2023

@jtracey93 conflicts have been resolved

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 4a1a1cd into Azure:main May 3, 2023
@picccard picccard deleted the subnet-routetables branch May 13, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - HubNetwork module removes UDR and NSG on redeployment
2 participants