Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused duplicate asn property #511

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

picccard
Copy link
Contributor

Overview/Summary

Default parameter object parVpnGatewayConfig and parExpressRouteGatewayConfig got the property asn defined both directly on the object and as a child prop to bgpsettings.

But the asn property is never used by the hubnetwork module, only the bgpsettings is passed when creating all vgw.
https://learn.microsoft.com/en-us/azure/templates/microsoft.network/virtualnetworkgateways

This PR fixes/adds/changes/removes

  1. Removes the asn property from parVpnGatewayConfig and parExpressRouteGatewayConfig

Breaking Changes

None

Testing Evidence

Changes has no impact on the resources created.

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 29, 2023
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 29, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 4265c12 into Azure:main Apr 29, 2023
@picccard picccard deleted the fix-unusedAsnProperty branch April 29, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants